Anyone object to this patch? We've never done anything useful with this, might as well stop wasiting users' time.
-- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
commit 8000066e4095b2876e0ec0f8561e641cbbcfe5fc Author: Phil Dibowitz <p...@ipom.com> Date: Thu Nov 28 15:07:37 2013 -0800 Disable config verifiction on HID remotes Since the beginning we've re-read the config under the guise that one day we'd actually compare what we were reading back to the actual file - but we don't do this and it takes a long time to read that data back. So I'm commenting this out and if anyone ever wants to implement proper verification we can put it back. Signed-off-by: Phil Dibowitz <p...@ipom.com> diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp index ee66b23..6e00ff9 100644 --- a/libconcord/libconcord.cpp +++ b/libconcord/libconcord.cpp @@ -616,9 +616,10 @@ static const uint32_t update_configuration_hid_stages[]={ LC_CB_STAGE_INVALIDATE_FLASH, LC_CB_STAGE_ERASE_FLASH, LC_CB_STAGE_WRITE_CONFIG, - LC_CB_STAGE_VERIFY_CONFIG, + // See comment in _update_configuration_hid() + //LC_CB_STAGE_VERIFY_CONFIG, }; -static const int update_configuration_hid_num_stages = 5; +static const int update_configuration_hid_num_stages = 4; static const uint32_t update_configuration_zwave_mh_stages[]={ LC_CB_STAGE_INITIALIZE_UPDATE, @@ -1295,9 +1296,14 @@ int _update_configuration_hid(lc_callback cb, void *cb_arg) { return err; } + // This has never actually done anything, so lets stop + // wasting users time re-reading the config until we are + // ready to actually do verification. + /* if ((err = verify_remote_config(cb, cb_arg))) { return err; } + */ if ((err = finish_config(cb, cb_arg))) { return err;
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel