On Mon, 27 Jan 2014, Phil Dibowitz wrote:

>> Remove unneeded code & includes.
>> On Windows, when performing config dumps, found that packets were being lost
>> but we were not detecting this.  Added code to check the sequence numbers of
>> the incoming packets.  Additionally, added a check after the loop to ensure
>> that the read did not time out.
>
> We don't need the win32api stuff anymore because we compile with mingw?
> Doesn't it still run as a windows console app though?
>
> And if we don't need that stuff, does that mean we don't need conio.h?

Correct - we don't need this stuff because of MinGW.  Actually, a big 
chunk of that was just setting the font color on the console to blue for 
the copyright message.  I'm not sure why we ever needed that.  :-)

We still need conio.h for _getch() I believe.

> Also, any idea on the missing packets? It's exactly what happens on MacOSX
> too. Since we use hidapi-raw on both mac and windows I'm very suspicious it's
> something in there, or the way we're using it.. but I haven't had time to
> recompile my kernel and test the behavior of hidapi-raw on linux....

Well, on one Windows 7 box, I found that if I increase the HID driver 
packet buffer size, the dropped packets went away.  So, I'm going to 
submit a patch to HIDAPI to do that.  On a Windows XP box, I still see 
occassional dropped packets even with the increased buffer size.  It 
doesn't appear that the buffer is getting overrun in that case.  I'm 
really not sure what to do - as best I can tell it might be a bug in the 
USB chipset driver or something.

In your situation, in which case are you seeing dropped packets?  Config 
update?  Config dump?  Or both?  And with which remote(s)?

------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable 
security intelligence. It gives you real-time visual feedback on key
security issues and trends.  Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to