On 03/16/2014 08:20 PM, Scott Talbert wrote: > On Sun, 16 Mar 2014, Phil Dibowitz wrote: > >>> Attached patch fixes the perl bindings... >>> >>> But it also fixes a bug in operationfile that couldn't handle firmware dump >>> files we created. >> >> BTW, any objections on the operationfile changes? If not, I'll merge. > > My only question about that is about the API change for > read_and_parse_file (int* to uint32_t*). Was there a reason for doing > that? If so, then we need to update the Python bindings, too.
It making more minimal changes to the perl bindings. It already understood that uint32_t* args were really "return values." I could teach it about int* as well, but it seems like uint32_t was more consistent anyway, so i went with that. I actually meant the part where you (I think you) had checked for an INFORMATION tag to "sanity check" - and now I fall through that if we don't find that tag... because otherwise we never recognize our own FW dump files. Alternatively, I could modify our FW dump code to add INFORMATION tags around the file... -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
