RE: config.sub patch: recognize four-part configuration name for VxWorks OS

[Xin, Peixing]

Hi John,

Thanks much for your solution and info. I made some slight changes so that 
things can be correct and more clear. If this one can be merged, appreciated.

Thanks,
Peixing

From: John Ericson <john.ericson@obsidian.systems>
Sent: Thursday, January 7, 2021 11:36 PM
To: Xin, Peixing <peixing....@windriver.com<mailto:eixing....@windriver.com>>; 
config-patches@gnu.org<mailto:config-patches@gnu.org>
Subject: Re: config.sub patch: recognize four-part configuration name for 
VxWorks OS


OK here is the my alternative that passes the same tests.

In case any is interested, let me talk about underlying issue that makes this 
so non-intuitive (more than I initially expected!) is that there is a tension 
between gnu config thinking

$kernel-$os

and other tools thinking

$os-$extra_info

(Even though the $kernel $os env vars are new from me in ~ last 2 years, 
config.sub was informally parsing that way for decades.)

This tension basically arose I think when someone reinterpreted linux-gnu not 
as GNU/linux, but Linux (an OS) + glibc ABI.

The result is config.sub to cope is calling things like `eabihf` or `musl` 
valid OSs to be filtered later, which is awkward and unintuitive.

Hopefully this can be untangled someday. (I would love to sit down with a bunch 
of interested parties and come up with e.g. a new JSON convention or something.)

John
On 1/7/21 10:13 AM, John Ericson wrote:

I don't this this patch is right. You are adding another "ad hoc" case, but we 
should strive not to do that. I will submit an alternative in a moment.
On 1/7/21 12:16 AM, Xin, Peixing wrote:
Hi ,

This patch is to recognize four-part configuration name for VxWorks. For 
example:
    armv7m-wrs-vxworks-eabihf
    armv7-wrs-vxworks-eabihf
    i686-wrs-vxworks-simlinux
    i686-wrs-vxworks-simwindows
    powerpc-wrs-vxworks-spe
    x86_64-wrs-vxworks-simlinux
    x86_64-wrs-vxworks-simwindows

    It's my check result on Ubuntu 18.04:

    $ make check
    cd testsuite && bash config-guess.sh && rm uname
    PASS: config.guess checks (131 tests)
    cd testsuite && bash config-sub.sh
    PASS: config.sub checks (846 tests)
    PASS: config.sub idempotency checks (783 tests)
    PASS: config.sub canonicalise each config.guess testcase (131 tests)

    * config.sub: Recognize four-part configuration name for VxWorks.
    * testsuite/config-sub.data: Add test cases.

Thanks,
Peixing

0001-Recognize-four-part-configuration-name-for-VxWorks.patch
Description: 0001-Recognize-four-part-configuration-name-for-VxWorks.patch