> This looks like a reasonable change, but one question: why not use > codecs.open() instead of open() in both the Python 2 and Python 3 case? I > just tried it locally by changing the open_file() definition to remove the if- > test and use codecs.open() unconditionally. It still worked (as I would > expect).
nice idea. fixed -- https://code.launchpad.net/~ricardokirkner/configglue/1196754-non-utf8-locale/+merge/173236 Your team Configglue developers is requested to review the proposed merge of lp:~ricardokirkner/configglue/1196754-non-utf8-locale into lp:configglue. _______________________________________________ Mailing list: https://launchpad.net/~configglue Post to : [email protected] Unsubscribe : https://launchpad.net/~configglue More help : https://help.launchpad.net/ListHelp
