On Fri, Jun 20, 2008 at 8:36 AM, Jeremy Maitin-Shepard <[EMAIL PROTECTED]> wrote:
> I don't think these are the correct hooks to be adding for this widget. > Neither of these events should indicate a change in the window size. > Instead, you probably should add an event listener to the window for the > "resize" event, and remember to remove the handler in the destroy method > (and also call the "superclass" destroy method via > this.__proto__.__proto__.destroy.call(this)). You are absolutely right. I will fix all of that before I resubmit. > Note that this will show the width and height of the top window itself, > as opposed to the width and height of the area filled by the webpage. > Is that intentional? (If so, what is the reason for wanting the width > and height of the top window?) > It is the way I need it (I need to know what a site will look like at a certain resolution with chrome); however, it would be trivial to create both types of widget so I will. :) It is not clear that this widget should be enabled by default. It > probably makes more sense to document it somewhere, e.g. the wiki, but > not make it the default. Anyone who wants it can just add that line > into his own rc file. > I will change that as well. I love conkeror, and it is a genuine privilege to be able to submit my humble changes. Thanks for your patience and advice. I will rewrite the mode line widgets and resubmit the patch. -DM
_______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
