On Mon, Mar 08, 2010 at 09:13:01PM +0100, Ricardo Buring wrote: > Compiling conkeror-spawn-helper.c with the the clang compiler [1] > generates the following warnings: > > --- > % clang -O2 -o conkeror-spawn-helper conkeror-spawn-helper.c > conkeror-spawn-helper.c:378:7: warning: non-void function 'main' > should return a value [-Wreturn-type] > return; > ^ > conkeror-spawn-helper.c:383:5: warning: non-void function 'main' > should return a value [-Wreturn-type] > return; > ^ > 2 diagnostics generated. > --- > > And indeed, main() is defined as returning an int. I think those > points of return can be replaced by return 0 for success (no errors). > The patch below performs this replacement. > > With this patch applied conkeror-spawn-helper.c compiles without > warnings and it seems to do its job just as well as it did when it was > compiled using GCC. >
Thank you. Pushed. -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
