On Mon, Feb 13, 2012 at 10:35:38PM +1030, David Kettler wrote:
> google-search-results-mode and other page-modes set the default browser
> object for various commands to make it convenient to select the most
> useful links. However, they do not restore the default when the page
> mode is disabled. A sufficient fix is to include a line like the
> following in the page mode's disable method:
>
> buffer.default_browser_object_classes = {};
>
> But page modes now operate more like emacs minor modes. If in the
> future we start having multiple page modes activated, each with their
> own idea of the default browser objects, then the fix above (and the
> current representation of the defaults) will not be sufficient. But it
> may not be worthwhile accomodating that possibility; it's not clear that
> it has any utility.
>
> In any case, I suggest that for now we install fixes as above.
>
> Affected page modes are:
>
> % grep -l default_browser_object_classes *
> google-images.js
> google-search-results.js
> reddit.js
> % grep -l media_setup_local_object_classes *
> dailymotion.js
> google-video.js
> youtube.js
>
> Regards, David
>
> P.S. It looks like media_scrapers also don't get cleaned up properly.
Thanks, fixed "good enough for now". Buffer-defaults for browser objects
was not a well designed feature, and I'll be returning to it later.
Media-scrapers is not currently part of the page-mode system.
--
John Foerch
_______________________________________________
Conkeror mailing list
[email protected]
https://www.mozdev.org/mailman/listinfo/conkeror
