[
https://issues.apache.org/jira/browse/CONNECTORS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901336#action_12901336
]
Karl Wright commented on CONNECTORS-91:
---------------------------------------
I looked at this. The patch seems correct for some classes, but for others it
is clearly incorrect, e.g. SynchronizeAll:
{
System.err.println("Usage: SynchronizeAll");
System.exit(1);
+ System.err.println("Successfully synchronized all agents");
}
Can you review your change for accuracy please?
Also, responding to the logging change - the log settings are global, and we
are trying for the least amount of setup work necessary to achieve a functional
system. Clearly, all log messages to stderr is not going to be reasonable for
people doing real crawls, so we'd need some way to segregate command output in
order to direct it differently than everything else, which implies at the least
you'd want a different logger, and then you'd also want to revise the
documented log4j properties, if you think we should go that route.
Re: testing. The testing you've done so far is best we can do at the moment,
unless you'd also like to write some unit tests. I don't think this would be
terribly difficult, but once again it would be time consuming. ;-)
> Making the initialization commands more useable
> -----------------------------------------------
>
> Key: CONNECTORS-91
> URL: https://issues.apache.org/jira/browse/CONNECTORS-91
> Project: Apache Connectors Framework
> Issue Type: Improvement
> Components: Framework core
> Reporter: Jettro Coenradie
> Fix For: LCF Release 0.5
>
> Attachments: change_commands.patch,
> change_commands_with_system_err_println.patch
>
>
> At the moment LCF comes with some classes that can be used to run command
> line to interact with the system. Examples are DBCreate, DBDrop and
> LockClean. I wanted to create a class that rebuilds my complete environment.
> So dropping a database, creating a database, cleaning the synch folder,
> registering agents, etc. Due to the structure of the classes with all the
> logic in the main method, I could not easily reuse these classes. In the
> patch I submit with issue I have refactored the current solution in a better
> reuseable solution that can still be called command line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
