[
https://issues.apache.org/jira/browse/CONNECTORS-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030669#comment-13030669
]
Karl Wright commented on CONNECTORS-197:
----------------------------------------
In the patch, the following lines look incorrect:
+" <option
value=\"sAMAccountName\""+(org.apache.manifoldcf.ui.util.Encoder.attributeEscape(userACLsUsername).equals("sAMAccountName")?"
selected=\"true\"":"")+">sAMAccountName</option>\n"+
+" <option
value=\"userPrincipalName\""+(org.apache.manifoldcf.ui.util.Encoder.attributeEscape(userACLsUsername).equals("userPrincipalName")?"
selected=\"true\"":"")+">userPrincipalName</option>\n"+
You want to attributeEscape the value attribute, not the equals compare. Other
than that, the patch looks good. Would you like to fix this and I will go
ahead and commit it?
> Active directory authority provides a compatibility switch for getting SID.
> ----------------------------------------------------------------------------
>
> Key: CONNECTORS-197
> URL: https://issues.apache.org/jira/browse/CONNECTORS-197
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Active Directory authority
> Reporter: Shinichiro Abe
> Priority: Minor
> Fix For: ManifoldCF next
>
> Attachments: CONNECTORS-197-temp.patch, CONNECTORS-197.patch
>
>
> When using "/UserACLs?username=foo@bar", MCF always refers to samAccountName
> now.
> Size of samAccountName is specified as less than 20 characters.
> Size of Login Name is specified as over 20 characters(256).
> if a user does not support old version of OS and support only new version, it
> is hard for ManifoldCF to restrict 20 characters of Login name.
> We want a compatibility switch in the configuration switch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
