[
https://issues.apache.org/jira/browse/CONNECTORS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116650#comment-13116650
]
Karl Wright commented on CONNECTORS-265:
----------------------------------------
The second patch makes the CMIS connector correct again, near as I can tell.
However, as a technology that we'd consider porting to other connectors as
well, there are some things we'll need to deal with. Specifically:
(1) Attribute escape vs. body escape vs. javascript escape. Each context has a
different escaping requirement, therefore we need a way to distinguish them
from one another. Possibilities include taking the escape code out of the
common method and putting it in the caller, or recognizing context by parsing
the HTML, etc.
(2) HTML snippets that repeat based on a loop. This is a common construct when
we build tables, and we must have a way to do it.
(3) Places where we need to talk to the connector in order to find information,
and how to handle errors in such cases. Usually this has a form something like
this:
{code}
<get connection>
try
{
... generate some html, possibly in a loop ...
}
catch (ManifoldCFException e)
{
... generate different html that gives an error ...
}
finally
{
<release connection>
}
{code}
This is also something we need to be able to do.
My suggestion is therefore to think through these cases before committing the
patches. Let's come up with a way to (for example) deal with the jcifs
connector, before claiming we have a good universal solution.
> Remove all the HTML snippets from the Java code
> -----------------------------------------------
>
> Key: CONNECTORS-265
> URL: https://issues.apache.org/jira/browse/CONNECTORS-265
> Project: ManifoldCF
> Issue Type: Improvement
> Components: CMIS connector
> Reporter: Piergiorgio Lucidi
> Assignee: Piergiorgio Lucidi
> Attachments: patch.txt, patch2.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> We have to start to remove all the HTML code inside Java classes, I started a
> refactoring to create a simple outputResource method that can be considered
> globally for all the connectors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
