Hi Fabien,

> +#define CONFIG_KEYS_MAX                2

[...]

> +#define SERVICE_KEYS_MAX               12
> +
> +gchar *config_possible_keys[CONFIG_KEYS_MAX] = {
> +     CONFIG_KEY_NAME,
> +     CONFIG_KEY_DESC,
> +};
> +
> +gchar *service_possible_keys[SERVICE_KEYS_MAX] = {
> +    SERVICE_KEY_TYPE,
> +    SERVICE_KEY_NAME,
> +    SERVICE_KEY_SSID,
> +    SERVICE_KEY_EAP,
> +    SERVICE_KEY_CA_CERT,
> +    SERVICE_KEY_CL_CERT,
> +    SERVICE_KEY_PRV_KEY,
> +    SERVICE_KEY_PRV_KEY_PASS,
> +    SERVICE_KEY_PRV_KEY_PASS_TYPE,
> +    SERVICE_KEY_IDENTITY,
> +    SERVICE_KEY_PHASE2,
> +    SERVICE_KEY_PASSPHRASE,
> +};

[...]

> +     /* Verify that provided keys are good */
> +     check_keys(keyfile, group, service_possible_keys, SERVICE_KEYS_MAX);
> +

Why don't use something like 

    sizeof(service_possible_keys)/sizeof(service_possible_keys[0])

instead of the SERVICE_KEYS_MAX? 

cheers,
daniel
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to