On Mon, Aug 30, 2010 at 05:33:13PM +0200, Fabien Marotte wrote: > + /* Verify that provided keys are good */ > + check_keys(keyfile, group, service_possible_keys, > + > sizeof(service_possible_keys)/sizeof(service_possible_keys[0])); > +
This line is a bit too long and looks also a bit nasty. BTW, you can check the coding style with checkpatch.pl from the linux tree. Just ignore the signed-off error. Maybe a macro like #define ARRAY_SIZE(a) (sizeof(a)/sizeof(a[0])) would be good to introduce. Since such a macro is quite usefull in other parts as well it should maybe go to a header file. I can remember some discussion about introducing something like the BUG macro from the linux kernel and moving it to a central header file. But this never happenend. I guess we have to wait until the maintainers are back from their holidays :) cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
