Hi Daniel,
On Thu, Sep 02, 2010 at 11:59:32AM +0200, Daniel Wagner wrote:
> Hi,
>
> The first patch "Handle several counters simultaniously" is
> the same as prevously posted ("[PATCH v3] Handle several counters
> simultaniously").
It looks fine to me. I'll push it after we push Pekka's service leak ones and
make a new release on top of that.
> I'm not so sure about patch 2. I kind like to have a global struct
> connman_stats_data structure to pass around. This allows some memcpy
> operation in patch 3 which are more efficiant then single assigments.
> But I can also do it with setters and getters.
>
> Patch 3 is still WIP, has a few ugly spots but generally it should
> show where I'm heading towards.
It looks like the right approach to me. I have a few initial comments that
I'll be sending as a reply to your v3 patch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
