Hi Pekka,
On Thu, Aug 26, 2010 at 05:26:50PM +0300, [email protected] wrote:
> From: Pekka Pessi <[email protected]>
>
> Modem Online property gets controlled with the cellular device Powered
> property.
So Marcel is fine with not keeping backward compatibility, let's see how that
goes. We'll do a ConnMan release in sync with an oFono one once this API
breakage is fixed.
A couple nitpicks:
> +static void set_online_reply(DBusPendingCall *call, void *user_data)
> +{
> + struct modem_data *modem;
> + DBusMessage *reply;
> + DBusError error;
> + gboolean result;
> +
> + DBG("path %s", (char *)user_data);
> +
> + if (modem_hash == NULL)
> + return;
> +
> + modem = g_hash_table_lookup(modem_hash, user_data);
> + if (modem == NULL)
> + return;
> +
> + reply = dbus_pending_call_steal_reply(call);
> +
> + dbus_error_init(&error);
> +
> + if (dbus_set_error_from_message(&error, reply)) {
> + connman_error("SetProperty(Online): %s: %s",
> + error.name, error.message);
Please fix this string, no ':', please.
> static int modem_disable(struct connman_device *device)
> {
> const char *path = connman_device_get_string(device, "Path");
>
> - DBG("device %p, path %s", device, path);
> + DBG("device %p, path, %s", device, path);
Useless change.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
