Hi Daniel,
On Wed, Oct 13, 2010 at 09:26:46AM +0200, Daniel Wagner wrote:
> From: Daniel Wagner <[email protected]>
>
> This avoid doing an hash table lookup from
> __connman_stats_service_register() right after
> inserting the stats_file pointer into it.
Thanks for that, I pushed it.
Cheers,
Samuel.
> ---
> src/stats.c | 22 ++++------------------
> 1 files changed, 4 insertions(+), 18 deletions(-)
>
> diff --git a/src/stats.c b/src/stats.c
> index 7d05b89..a4fcc9e 100644
> --- a/src/stats.c
> +++ b/src/stats.c
> @@ -201,19 +201,6 @@ static void stats_free(gpointer user_data)
> g_free(file);
> }
>
> -static int stats_create(struct connman_service *service)
> -{
> - struct stats_file *file;
> -
> - file = g_try_new0(struct stats_file, 1);
> - if (file == NULL)
> - return -ENOMEM;
> -
> - g_hash_table_insert(stats_hash, service, file);
> -
> - return 0;
> -}
> -
> static void update_first(struct stats_file *file)
> {
> file->first = (struct stats_record *)
> @@ -362,12 +349,11 @@ int __connman_stats_service_register(struct
> connman_service *service)
>
> file = g_hash_table_lookup(stats_hash, service);
> if (file == NULL) {
> - err = stats_create(service);
> -
> - if (err < 0)
> - return err;
> + file = g_try_new0(struct stats_file, 1);
> + if (file == NULL)
> + return -ENOMEM;
>
> - file = g_hash_table_lookup(stats_hash, service);
> + g_hash_table_insert(stats_hash, service, file);
> } else {
> return -EALREADY;
> }
> --
> 1.7.2.3
>
> _______________________________________________
> connman mailing list
> [email protected]
> http://lists.connman.net/listinfo/connman
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
