Hello,

Here are rewritten patches for manual proxy support, and now it also provides the patch to "run" the manual configuration.

So URI parsing/validation is done without regex.
URI are parsed only once: when setting the configuration.
To keep a good performance/memory ratio it fulfils a specific structure for exclude URI and dermine wether we are on a generic proxy server or on a list of protocol specific based ones.

Excludes list follows this URI format: <protocol://><rule> (at least one on 2 should be set)
About excluding rules, I kept only these ones:
- <*>keyword -> all hostname ending with keyword ('*' is optional)
- keyword*   -> all hostname starting with keyword
- *keyword*  -> all hostname made with keyword

if protocol if set, rule applies if only protocol applies. (if no rule but only protocol: only protocol applies)

About server list, it can take such URI:
<protocol://><<login>:<pass>@><hostname><:port></> (at least hostname should be set)

No interpretation is made, just validation among hostname and port format.

All is done in same function, which is used to parse the given url as well (to get its protocol).

The only "lacking" part is the given server in case of generic context, only the first one is provided. But I guess it will have to provide a list at some point no? Easy fix anyway.

I hope code style is fine, but there are probably function signatures (like __pacrunner_manual_execute() ?), variables names at least.

Best regards,

Tomasz

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to