Hi Mohamed,
On Wed, Dec 08, 2010 at 04:37:11PM -0800, Mohamed Abbas wrote:
> If we are scanning then don't try to run autoconnect while
> we are adding network from scan, at the end of scan auto
> connect will be called.
The patch makes sense, I just have a couple comments:
> ---
> include/device.h | 2 ++
> src/device.c | 6 ++++++
> src/service.c | 8 ++++++--
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/include/device.h b/include/device.h
> index c5e005d..609ae0b 100644
> --- a/include/device.h
> +++ b/include/device.h
> @@ -100,6 +100,8 @@ void connman_device_unregister(struct connman_device
> *device);
> void *connman_device_get_data(struct connman_device *device);
> void connman_device_set_data(struct connman_device *device, void *data);
>
> +connman_bool_t is_device_scanning(struct connman_device *device);
> +
So your routine should be kept internal to ConnMan core, as you only need it
from service.c
As a consequence it should be defined in src/connman.h, and should be called
__connman_device_is_scanning().
> struct connman_device_driver {
> const char *name;
> enum connman_device_type type;
> diff --git a/src/device.c b/src/device.c
> index b8110c4..667fed6 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -810,6 +810,12 @@ void __connman_device_cleanup_networks(struct
> connman_device *device)
> remove_unavailable_network, NULL);
> }
>
> +connman_bool_t is_device_scanning(struct connman_device *device)
> +{
> +
Unneeded new line here.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
