Hi Mohamed,
On Wed, Dec 08, 2010 at 04:37:18PM -0800, Mohamed Abbas wrote:
> There is a small time interval from the time from start a connect
> to a network and receiving AUTH and ASSOC signal from supplicant
> that cause is_connecting to report FALSE when we are in
> the process of connecting.
Nice catch. Couldn't we fix that with that patch:
diff --git a/src/service.c b/src/service.c
index 626cd31..5c692df 100644
--- a/src/service.c
+++ b/src/service.c
@@ -306,6 +306,9 @@ static connman_bool_t is_connecting(struct connman_service
*service)
switch (service->state) {
case CONNMAN_SERVICE_STATE_UNKNOWN:
case CONNMAN_SERVICE_STATE_IDLE:
+ if (service->network == NULL)
+ return FALSE;
+ return __connman_network_get_connecting(service->network);
case CONNMAN_SERVICE_STATE_FAILURE:
case CONNMAN_SERVICE_STATE_DISCONNECT:
case CONNMAN_SERVICE_STATE_READY:
> Also in __connman_service_auto_connect function we not want
> to start connecting if another service is connected or in process,
> since service_list does not sort connecting services we can
> start connection while another service is already connecting.
That's a perfectly valid issue, yes.
However I think this needs to be fixed by actually sorting the services
properly, i.e. by putting the connecting services right after the READY/ONLINE
ones. Could you please come up with a separate patch for that ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
