Hi Julien,
On Fri, Dec 10, 2010 at 11:00:36AM +0000, Julien Massot wrote:
> +static void ipv4ll_available_cb(GDHCPClient *dhcp_client, gpointer user_data)
> +{
> + struct connman_dhcp *dhcp = user_data;
> + char *address, *netmask;
> +
> + DBG("IPV4LL available");
> +
> + address = g_dhcp_client_get_address(dhcp_client);
> + if (address != NULL)
> + connman_dhcp_set_value(dhcp, "Address", address);
> +
> + netmask = g_dhcp_client_get_netmask(dhcp_client);
> + if (netmask != NULL)
> + connman_dhcp_set_value(dhcp, "Netmask", netmask);
address and netmask can be freed now.
> static int dhcp_request(struct connman_dhcp *dhcp)
> {
> GDHCPClient *dhcp_client;
> @@ -146,15 +173,25 @@ static int dhcp_request(struct connman_dhcp *dhcp)
> lease_available_cb, dhcp);
>
> g_dhcp_client_register_event(dhcp_client,
> + G_DHCP_CLIENT_EVENT_IPV4LL_AVAILABLE,
> + ipv4ll_available_cb, dhcp);
> +
> + g_dhcp_client_register_event(dhcp_client,
> G_DHCP_CLIENT_EVENT_LEASE_LOST, lease_lost_cb, dhcp);
>
> g_dhcp_client_register_event(dhcp_client,
> + G_DHCP_CLIENT_EVENT_IPV4LL_LOST, ipv4ll_lost_cb, dhcp);
> +
> + g_dhcp_client_register_event(dhcp_client,
> G_DHCP_CLIENT_EVENT_NO_LEASE, no_lease_cb, dhcp);
>
> connman_dhcp_set_data(dhcp, dhcp_client);
>
> g_dhcp_client_ref(dhcp_client);
>
> + g_dhcp_client_set_debug(dhcp_client,
> + dhcp_debug, dhcp);
> +
This is not needed, set_debug is already called from dhcp_request().
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
