Hi Daniel, On Mon, Dec 13, 2010 at 03:07:56PM +0100, Daniel Wagner wrote: > From: Daniel Wagner <[email protected]> > > We should add the routing entries pushed by the OpenVPN server. > --- > include/inet.h | 3 ++- > include/provider.h | 4 ++++ > src/connection.c | 5 +++-- > src/inet.c | 13 ++++++++++--- > src/provider.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > src/service.c | 6 ++++-- > 6 files changed, 70 insertions(+), 8 deletions(-) A couple comments on this one:
- What you're trying to add are network routes, so I'd prefer to have a new API, connman_inet_[add|delete]_network_route(). To avoid code duplication, you could have the current connman_inet_add_host_route() being a wrapper around the connman_inet_add_network_route(), with a NULL argument. - Also, I'd like to see the inet API addition and the provider usage of this new API as separate patches. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
