Hi Jukka, On Wed, Dec 15, 2010 at 01:10:20PM +0200, Jukka Rissanen wrote: > --- > include/ipconfig.h | 11 ++++++----- > plugins/ofono.c | 1 + > src/ipconfig.c | 9 +++++++++ > src/network.c | 5 +++++ > 4 files changed, 21 insertions(+), 5 deletions(-) The patch looks good, I just have one question:
> diff --git a/src/network.c b/src/network.c > index 57d873a..8083c7b 100644 > --- a/src/network.c > +++ b/src/network.c > @@ -760,6 +760,7 @@ static gboolean set_connected(gpointer user_data) > break; > case CONNMAN_IPCONFIG_METHOD_FIXED: > case CONNMAN_IPCONFIG_METHOD_MANUAL: > + case CONNMAN_IPCONFIG_METHOD_AUTOCONF: > ret = manual_ipv6_set(network, ipconfig_ipv6); Do we really want to manually set the IPv6 address in the AUTOCONF case ? If IPv6 autoconfiguration is enabled at the kernel level, the kernel will actually set the address by itself. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman
