Hi Mohamed, On Thu, Dec 23, 2010 at 01:21:54AM +0100, Samuel Ortiz wrote: > Hi Mohamed, > > On Mon, Dec 20, 2010 at 11:07:34AM -0800, Mohamed Abbas wrote: > > This patch fix the race condition that caused more than one service > > to start connecting at the same fime by: > > > > * Make sure is_connecting always returning the right status of > > the network and dont allow the small intevel until get the > > G_SUPPLICANT_STATE_AUTHENTICATING or G_SUPPLICANT_STATE_ASSOCIATING > > signal from supplicant. > > > > * Fix serving soring so connecting service will make it in the top > > so auto_connect search will work. > > > > * Dont need device->connected in end scan to decide to call > > auto_connect. > > > > This patch used Samuel patch and add to it. > > case CONNMAN_SERVICE_STATE_UNKNOWN: > > case CONNMAN_SERVICE_STATE_IDLE: > > case CONNMAN_SERVICE_STATE_FAILURE: > > + if (service->network != NULL) > > + return __connman_network_get_connecting( > > + service->network); > > case CONNMAN_SERVICE_STATE_DISCONNECT: > The patch by itself looks fine to me. However, I'd like to see it splitted in > 2: 1 for the network.c and service.c changes and then another one for not > using disconnected anymore. I actually did that, as I was trying to fix some autoconnect issues. I added some more commits on top of it, which seems to provide a reliable auto connection behaviour. Could you please give it a try and let me now how that works for you ?
Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
