Hi Samuel, On Mon, Feb 07, 2011 at 01:14:17AM +0100, Samuel Ortiz wrote: > Hi Daniel, > > On Thu, Feb 03, 2011 at 05:33:38PM +0100, Daniel Wagner wrote: > > From: Daniel Wagner <[email protected]> > The dhcp_start/stop and callback design is definitely heading in the right > direction. > I have some minor comments though: > > > --- a/src/connman.h > > +++ b/src/connman.h > > @@ -298,6 +298,14 @@ void __connman_timeserver_cleanup(void); > > int __connman_dhcp_init(void); > > void __connman_dhcp_cleanup(void); > > > > +struct connman_dhcp_notify { > > + void (* valid) (struct connman_network *network); > > + void (* invalid) (struct connman_network *network); > > +}; > I would prefer a: > typedef void (* dhcp_cb) (struct connman_network *network, int error); Ah, only one callback and if error == 0 than we do a dhcp_success below and in the case of error < 0 a dhcp_failure?
> > +static void dhcp_invalid(struct connman_dhcp *dhcp) > Here I'd prefer a dhcp_failure/success() naming. No problem. thanks, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
