Hi,
while checking connman's traces I've noticed dhcp_release is called twice on same pointer when releasing dhcp connection (due to manual setting or unplugging wire). I suggest following correction cause dhcp_release is called by removing hash table entry due to line 458 :network_table = g_hash_table_new_full(g_direct_hash, g_direct_equal, NULL, remove_network) :

---
 src/dhcp.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/dhcp.c b/src/dhcp.c
index 03a2b90..2656c1c 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -446,8 +446,6 @@ void __connman_dhcp_stop(struct connman_network *network)
        if (dhcp == NULL)
                return;

-       dhcp_release(dhcp);
-
        g_hash_table_remove(network_table, network);
 }

--
1.7.1

regards
Thierry

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to