Hi Grant, On Wed, Jun 01, 2011 at 10:28:38AM -0700, Grant Erickson wrote: > Check for NULL dhcp pointers in dhcp_free and dhcp_release. Although those checks are definitely harmless, here are my comments: dhcp_free() is only called from dhcp_invalidate(), which already runs a dhcp NULL check. dhcp_release() is called from the hash table removal path, and GLib guarantees that the remove hook will not be called on a NULL pointer.
So I think we don't need those checks for now (as opposed to what i told you on IRC, sorry about that). Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
