Hi Thierry,
On Wed, Jun 29, 2011 at 10:37:51PM +0200, Thierry Boureille wrote:
> Hi Marcel,
> indeed, please find a more readable patch suggestion
>
> Best regards
> Thierry
>
> ---
> plugins/ofono.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index 0c23462..b75a1fd 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -422,6 +422,7 @@ static void set_connected(struct network_info *info,
>
> switch (info->ipv4_method) {
> case CONNMAN_IPCONFIG_METHOD_UNKNOWN:
> + goto ipv6;
> case CONNMAN_IPCONFIG_METHOD_OFF:
> case CONNMAN_IPCONFIG_METHOD_MANUAL:
> case CONNMAN_IPCONFIG_METHOD_AUTO:
> @@ -442,6 +443,10 @@ static void set_connected(struct network_info *info,
> break;
> }
>
> + connman_network_set_connected(info->network, connected);
> + return;
That looks quite better yes. But it breaks the dual stack case where you have
both v4 and v6 method set. So we probably need to set a flag in this routine,
leave the connman_network_set_connected() call where it is right now, and call
it depending on the flag (true if any of the v4 or v6 method is fixed or
dhcp).
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
