Hi Tomasz, > >> gboolean g_resolv_cancel_lookup(GResolv *resolv, guint id); > >> > >> +gboolean g_resolv_set_result_address_family(GResolv *resolv, int family); > >> + > > why is not using g_web_set_address_family() enough and just restrict > > outgoing and result at the same time? > gweb is not used in wpad (or then in download_pac() but it's currently > empty), only g_resolv. > > I first played with getaddrinfo() in wpad.c to filter out gresolv > results but it was a bit overkill since we get struct sockaddr and I had > so run inet_ntop to get char* back. > I did that to follow the wpad.c current logic. > Of course if the plan is to drop this gresolv thing and only use gweb in > wpad.c then yes such patch is irrelevant.
I got myself properly confused between GWeb and GResolv ;) Lets just add a g_resolv_set_address_family() and use it for outgoing and result restrictions on IPv4 and IPv6. That way it is similar in both entities and g_web_set_address_family() can just call the GResolv one to restrict it as well. Since there is no point in dealing with IPv6 results if you know you have to restrict yourself to IPv4. Regards Marcel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
