Hi Everyone, On 07/01/2011 09:49 AM, Tomasz Bursztyka wrote: > Please review,
Tomasz and me had a discussion on IRC: Two nitpicks: - the last patch has a whitespace damage - __connman_service_indicate_state() could be made static We noticed that this task isn't finished. This series fixes the ipconfig state but not the service state. That means the service still goes directly from nothing to READY -> ONLINE for ethernet. Tomasz suggested to introduce a combine_state() for the service state. The current combine_state() handles the ipconfig state. For me it sounds reasonable. Comments? cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
