Hi Samuel, On 07/06/2011 05:41 PM, Samuel Ortiz wrote: > Hi Daniel, > > On Fri, Jul 01, 2011 at 06:15:45PM +0200, Daniel Wagner wrote: >> From: Daniel Wagner <[email protected]> >> >> --- >> src/device.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/src/device.c b/src/device.c >> index 386be44..ada9233 100644 >> --- a/src/device.c >> +++ b/src/device.c >> @@ -1116,8 +1116,6 @@ int connman_device_remove_network(struct >> connman_device *device, >> if (network == NULL) >> return 0; >> >> - __connman_network_set_device(network, NULL); >> - > I may be missing some logic, but then who is calling network_remove() for the > removed network ?
On the next line we remove the network from the device->networks hash table. When it's removed from the hash table, unregister_network() is called which does a __connman_network_set_device(network, NULL) again. Therefore I though the one above it is not necessary. Do I miss something? cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
