From: Daniel Wagner <[email protected]>

valgrind reports that __connman_service_nameservers_remove leaks
memory.

g_strv_length already returns the right size of the new array.
---
 src/service.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/service.c b/src/service.c
index b8f6aac..e793d75 100644
--- a/src/service.c
+++ b/src/service.c
@@ -585,7 +585,7 @@ int __connman_service_nameserver_remove(struct 
connman_service *service,
                return 0;
        }
 
-       servers = g_try_new0(char *, len - 1);
+       servers = g_try_new0(char *, len);
        if (servers == NULL)
                return -ENOMEM;
 
@@ -595,7 +595,7 @@ int __connman_service_nameserver_remove(struct 
connman_service *service,
                        j++;
                }
        }
-       servers[len - 2] = NULL;
+       servers[len - 1] = NULL;
 
        g_strfreev(service->nameservers);
        service->nameservers = servers;
-- 
1.7.6

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to