Hi Henri,
On Thu, Jul 28, 2011 at 05:18:14PM +0300, Henri Bragge wrote:
> URL can now be cleared and updates will be propagated over DBus.
> This could introduce a need to null-check values where this function
> is used (src/dhcp.c, src/network.c, src/provider.c). However, src/dhcp.c
> requires that URL can be cleared.
There are 2 fixes here, so I'd rather see 2 separate patches.
One additional comment:
> ---
> src/service.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index d442c16..48b149d 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -2026,11 +2026,10 @@ int __connman_service_timeserver_remove(struct
> connman_service *service,
> void __connman_service_set_pac(struct connman_service *service,
> const char *pac)
> {
> - if (pac == NULL)
> - return;
> -
> g_free(service->pac);
> service->pac = g_strdup(pac);
> +
> + proxy_configuration_changed(service);
proxy_changed() is enough here.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
