Hi Alban, On Wed, Aug 24, 2011 at 01:15:15PM +0100, Alban Crequy wrote: > Le Tue, 23 Aug 2011 18:32:20 +0200, > Samuel Ortiz <[email protected]> a écrit : > > > Hi Alban, > > > > On Wed, Aug 17, 2011 at 04:41:38PM +0100, Alban Crequy wrote: > > > @@ -77,12 +77,12 @@ static char **extract_result(const char *str) > > > result[0] = NULL; > > > result[1] = NULL; > > > > > > - if (strcmp(str, "DIRECT") == 0) { > > > + if (strcasecmp(str, "DIRECT") == 0) { > > > result[0] = strdup("direct://"); > > > return result; > > > } > > > > > > - if (strncmp(str, "PROXY ", 6) == 0) { > > > + if (strncasecmp(str, "PROXY ", 6) == 0) { > > So those 2 changes are not related to this patch. Moreover, why would > > we want to be case-insensitive now ? > > In order to be compatible with existing PAC files which return > something like "proxy server:port". They work on Windows but they would > not work if pacrunner is case-sensitive. I was under the impression that only upper case strings were accepted, but I guess not. Thanks Windows.
> We don't lose anything by accepting those existing PAC files in my > opinion. libproxy is also case-insensitive. > > I'm not sure if there was any consensus in our discussion on IRC > yesterday. I think it basically was that case insensitiveness is fine but the SOCKS4a is not at that point. Please send me 2 patches: One that adds case insensitiveness to the existing code, and another one for adding SOCKS, SOCKS4 and SOCKS5 support. Thanks in advance. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
