Hi,

On Mon, Aug 29, 2011 at 10:48 AM, Yu A Wang <[email protected]> wrote:

> Fix unable to enable/disable 3G service after unplug/plug in again
>
> Fix BMC#13547
> ---
>  src/technology.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/technology.c b/src/technology.c
> index a067d68..187d2f0 100644
> --- a/src/technology.c
> +++ b/src/technology.c
> @@ -750,6 +750,7 @@ int __connman_technology_remove_device(struct
> connman_device *device)
>        DBG("device %p", device);
>
>        type = __connman_device_get_service_type(device);
> +       __connman_notifier_disable(type);
>        __connman_notifier_unregister(type);
>
> Why do u need   __connman_notifier_disable here?

       technology = technology_find(type);
> @@ -759,8 +760,8 @@ int __connman_technology_remove_device(struct
> connman_device *device)
>        technology->device_list = g_slist_remove(technology->device_list,
>                                                                device);
>        if (technology->device_list == NULL) {
> -               technology->state = CONNMAN_TECHNOLOGY_STATE_OFFLINE;
> -               state_changed(technology);
> +               technology->refcount = 1;
> +               technology_put(technology);
>        }
>
>        return 0;
>
Why do u need to hardcode the refcount ?  wouldnt technology_put take care
of it ?

> --
>
Cheers,
Alok.

> 1.7.2.2
>
> _______________________________________________
> connman mailing list
> [email protected]
> http://lists.connman.net/listinfo/connman
>
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to