Hi Arron,

On Mon, Aug 29, 2011 at 03:48:55AM -0400, Yu A Wang wrote:
> @@ -317,11 +317,14 @@ static int modem_enable(struct connman_device *device)
>       return modem_change_online(path, TRUE);
>  }
>  
> +static void remove_device_networks(struct connman_device *device);
> +
No forward declarations, please.


>  static int modem_disable(struct connman_device *device)
>  {
>       const char *path = connman_device_get_string(device, "Path");
>  
>       DBG("device %p path %s", device, path);
> +     remove_device_networks(device);
I'd prefer to call this one when we do get an Online property changed to
FALSE. We want to avoid removing all cellualr networks while the modem failed
to be powered down.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to