Hi Marcel,

I might change this name to pacrunner_manual_test or something like that.

About a more generic and integrated tool on unit testing for pacrunner,
why not.  At least for manual configuration support it would be possible
this way:
For instance, we would create a pacrunner.h stub file into tools/ that
declares
__pacrunner_manual_init(), __pacrunner_manual_cleanup(),
__pacrunner_manual_execute(), etc... functions. We would create a
symlink to ../src/manual.c (or Makefile might help to use the file
directly actually) and that's it: the tool source would uses those
files, and implements the command line stuff. It would be possible then
to test some misswritten URIs and so on ... (like it is possible with my
current patch)
Well at least this would not create the need to insert dirty macros into
the core source.
It should be somehow possible to do the same for js stuff. Such tool
could be used externally with a fuzzer also (mostly on URIs again)
Let's see, if I have enough time for it.

Anyway, my priority was to propose an implementation of this manual
configuration support and I thought it was easier to experience it this
way (and not directly into the core, via dbus interface). I hope it
answers the problem well enough so I will be able to propose this
solution in the core itself as soon as you will have reviewed this proposal.

Thanks,

Tomasz



Le 13/09/2011 16:43, Marcel Holtmann a écrit :
> Hi Tomasz,
>
>>  Makefile.am    |    5 +-
>>  tools/manual.c |  732 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 736 insertions(+), 1 deletions(-)
>>  create mode 100644 tools/manual.c
> the name is a bit too generic ;)
>
> However I think if we can turn this into a proper unit test that also
> utilizes PACrunner code (and not just copied skeletons) then this could
> be super useful. Any ideas on how to achieve that?
>
> Regards
>
> Marcel
>
>
> _______________________________________________
> connman mailing list
> [email protected]
> http://lists.connman.net/listinfo/connman
>

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to