Hi Tomasz, On Fri, Sep 02, 2011 at 02:30:53PM +0300, Tomasz Bursztyka wrote: > Hello, > > As an introduction to connman's core iptables API, I started to improve > iptables-test tool first. > I added some features which adds the capability to play atomically against > netfilter rules. > This was the result of previous discussion about Personnal Firewall feature > we had. > (see http://lists.connman.net/pipermail/connman/2011-July/005429.html ) > > So, this patch-set adds capability to: > > - insert a rule. > - delete selectively a rule. > - load necessary kernel modules when it's ran The patchset looks good to me. I decided to go ahead and apply it but got this:
tools/iptables-test.c: In function ‘main’: tools/iptables-test.c:743:41: error: ‘xt_e_m’ may be used uninitialized in this function [-Werror=uninitialized] tools/iptables-test.c:763:25: note: ‘xt_e_m’ was declared here tools/iptables-test.c:1252:28: error: ‘chain_head’ may be used uninitialized in this function [-Werror=uninitialized] tools/iptables-test.c:1210:9: note: ‘chain_head’ was declared here tools/iptables-test.c:1200:26: error: ‘table’ may be used uninitialized in this function [-Werror=uninitialized] tools/iptables-test.c:1137:27: note: ‘table’ was declared here Would you mind fixing those please ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
