Hi Danny, On Wed, Oct 05, 2011 at 01:12:20PM +0900, Danny Jeongseok Seo wrote: > Hi, > > It was discussed with sameo in IRC: Failure of Wi-Fi auto_connect > The latest ConnMan refer device->connections only for checking auto_connect > trigger and setting device->backoff_interval = SCAN_INITIAL_DELAY when > device->connections == 0. > However, device->connections is not updated properly in set_connected(); it > increases twice one for ipv6 method and another for ipv4 method, but it > decreases only by one. > That makes impossible to Wi-Fi auto_connect. > > I also agreed with sameo's last comment: > <sameo> DannyJSSeo: Could you try building a patch that actually gets rid > of device->connections entirely ? From connman_device_set_scanning() , > simply call __connman_service_auto_connect(); without checking for device- > >connections. > <sameo> DannyJSSeo: __connman_service_auto_connect() already checks if > we're connecting or not, so we can call it directly. So, all in all, I > think we can just get rid of device->connections entirely, along with > device_decrease_connections() and device_increase_connections(). > > Check my patch (based on latest 0.77.2 stable) and let's fix the issue > together. > Please get back to any comments So the patch itself looks good. Before I can apply it, please do the following:
- Generate it against ConnMan upstream. Once applied, we will backport it to connman-stable. - Inline it into your email. Without doing so, it gets quite difficult to review it by simply replying to the email. - Make your patch subject shorter, and explain what you're trying to do and most importantly hwy you're trying to do it in you patch commit log. Try to think about people who will look at your patch without any of your context: The first thing they would ask themselves is why did he remove the connections field. Many thanks for the fix. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
