Hi Daniel, > Make sure all file descriptor are closed. > --- > plugins/tist.c | 4 ++-- > plugins/vpn.c | 4 ++-- > src/inet.c | 2 +- > src/resolver.c | 2 +- > src/rfkill.c | 4 ++-- > src/stats.c | 2 +- > src/timezone.c | 10 +++++----- > tools/alg-test.c | 2 +- > tools/stats-tool.c | 3 ++- > tools/tap-test.c | 2 +- > tools/wispr.c | 2 +- > 11 files changed, 19 insertions(+), 18 deletions(-)
can you split this at least into core:, tools: and plugins: with proper prefixes for the commit subjects. And just fixing up open() is not enough. Also have a look at socket() and add SOCK_CLOEXEC there as well. In src/config.c we also have an inotify_init() call that needs to be changed into non blocking and cloexec. And also signalfd() call needs a modification. Of course a similar sweep through is needed for oFono. Regards Marcel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
