Hi,

This is a new patchset about service state (being online or not) and moving it 
up/down.

- first patch fixes BMC#23671: only one service can be set to online.
Replaces previous patchset (see: 
http://lists.connman.net/pipermail/connman/2011-November/007192.html )
- second patch is trickier, actually: move up/down service was broken in a 
sense that if we are moving down an online service, this one 
should go back to ready (it's service state, not it's ipconfig state, big 
difference here) and the new up service should recompute its 
service state if relevant, i.e: if it's a service that can come up online, it 
will check so (restart wispr/portal check).
- third patch is not mandatory to include but I would personally preffered it 
got pusched since it removes a public function which was
giving the possibility from outside service to downgrade the state of a 
service. Due to second patch this function is no more useful as public and 
moreover: it's definitely much better that service handles its state by itself 
(which state changes according to ipconfig state which can be 
handled externaly)

Please review,

Tomasz Bursztyka (3):
  service: only one service online at a time
  service: when moving service up, its state will be recomputed
  service: state downgrading cannot be done from anywhere but in
    service

 src/connection.c |    2 -
 src/connman.h    |    1 -
 src/service.c    |  108 +++++++++++++++++++++++++++++++++++++++++++-----------
 3 files changed, 86 insertions(+), 25 deletions(-)

-- 
1.7.8.rc3

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to