Hi Tomasz,
The patch looks good, I just have one picky comment:
On Tue, Nov 29, 2011 at 01:45:29PM +0200, Tomasz Bursztyka wrote:
> Fixes BMC#23715
> ---
> src/service.c | 16 +++++++++++-----
> 1 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index bb01e6f..f2e597f 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -5564,12 +5564,13 @@ struct connman_service *
> __connman_service_create_from_network(struct connman_ne
>
> void __connman_service_update_from_network(struct connman_network *network)
> {
> + connman_bool_t need_sort = FALSE;
> struct connman_service *service;
> + connman_bool_t stats_enable;
> connman_uint8_t strength;
> connman_bool_t roaming;
> GSequenceIter *iter;
> const char *name;
> - connman_bool_t stats_enable;
The stats_enable move is not needed, could you please fix it ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
