Hi Patrik, On Fri, Dec 02, 2011 at 04:18:19PM +0200, [email protected] wrote: > From: Patrik Flykt <[email protected]> > > Hi, > > Version 2 of this patch set is a rebase on current HEAD. > > > Currently, 'ConnectService' manager method call has been the only way of > connecting hidden WiFi networks. This patch set changes the status quo > so that hidden networks are listed together with any other services > (patch 01). There is no point in modifying the presented hidden networks > (patch 02), as they are not unique until configured with an SSID. > > Thus, when net.connman.Service.Connect is called, an SSID or Name is > requested via the Agent API (patches 03,08). When an SSID or a Name found in > the reply from the agent (patches 09-11), a scan is done for the hidden > SSID (patch 15). Hidden SSID scan support is provided (patches 12,13) as well > as the implementation for WiFi (patch 17). If the SSID is found, the service > detected will be connected instead (patch 16). > > authentication_cb_t is now more explicit on when values resp. cancel is > received from the agent (patches 04-06). A helper function for determining if > a service is hidden was added (patch 07) and passphrase setting was factored > out (patch 14). > > I have noticed that when the hidden scan is done, wpa_supplicant sometimes > doesn't find the network in question and thus fails to connect to it. So I applied this patchset, thanks a lot. A few remarks:
- We're still not entirely fixing the hidden network reconnection with this patchset. This will work most of the time with the fast connect code, provided that the HW supports it. If it doesn't then we should probably try an active scan on an hidden networks if there are hidden networks around that match the security scheme of some of the e.g. last 4 connected APs, and if some of those 4 APs are hidden. - As you said, we don't check if the SSID we get from the agent response is already on the service list or not. - At that point, I'd like to see one single device scan routine that takes a device pointer and some scan parameters as arguments. The passive, fast and hidden scan code would use the same device scanning hook. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
