Hi Daniel,
On 15/12/2011 14:19, Daniel Wagner wrote:
Hi Guillaume,
On 15.12.2011 13:42, Guillaume Zajac wrote:
And I would prefer this
netreg_update_strength()
{
uint8_t strength;
if (modem->data_strength == 0)
strength = modem->strength;
else
strength = modem->data_strength;
connman_network_set_strength();
connman_network_update();
}
Why updating ConnMan network signal strangthwith data_strength if it is
not equal to 0? We would update twice data_strength.
Because the ConnMan network signal strength should have been already
updated with data_strength signal change notification, right?
Maybe I just don't really understand the interaction between strength
and data_strength. It is rather confusing that part. So my comment is
likely just bogus. I might just wait for the comment then :)
Ok, if my comment is not clear enough, tell me ;)
Kind regards,
Guillaume
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
