Hi Alok,
A few comments:
On Wed, Jan 25, 2012 at 02:16:40PM +0200, Alok Barsode wrote:
> @@ -82,6 +82,18 @@ static gint compare_priority(gconstpointer a,
> gconstpointer b)
> return driver2->priority - driver1->priority;
> }
>
> +static void rfkill_check(gpointer key, gpointer value, gpointer user_data)
> +{
> + int index = (int)key;
You don't need this one, you can use rfkill->index instead.
> + struct connman_rfkill *rfkill = value;
> + enum connman_service_type type = (enum connman_service_type)user_data;
Please add a space between (enum connman_service_type) and user_data.
> @@ -121,6 +133,11 @@ int connman_technology_driver_register(struct
> connman_technology_driver *driver)
> __connman_technology_add_device(device);
> }
>
> +check_rfkill:
> + /* Check for orphaned rfkill switches. */
> + g_hash_table_foreach(rfkill_list, (GHFunc)rfkill_check,
The GHFunc cast is not needed.
The rest of the patch looks fine.
Please fix patch #1 according to Patrik's comment and I'll push this patchset.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
