Hi,
On Mon, 2012-01-30 at 09:46 +0100, Daniel Wagner wrote:
> From: Daniel Wagner <[email protected]>
>
> ---
> src/manager.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/src/manager.c b/src/manager.c
> index 941bf5f..7bad80d 100644
> --- a/src/manager.c
> +++ b/src/manager.c
> @@ -121,6 +121,9 @@ static DBusMessage *set_property(DBusConnection *conn,
> return NULL;
> }
>
> + connman_dbus_property_changed_basic(CONNMAN_MANAGER_PATH,
> + CONNMAN_MANAGER_INTERFACE, "SessionMode",
> + DBUS_TYPE_BOOLEAN, &sessionmode);
> } else
> return __connman_error_invalid_property(msg);
I think it would be better to have this functionality in
__connman_session_set_mode() instead, so that the property update would
be sent in one place only. If I read the code correctly, the above one
would send a property changed even if the mode didn't change.
Cheers,
Patrik
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
