Hi Patrik, Some comments below about dbus usage,
Le 08/02/2012 11:09, [email protected] a écrit : > + > + dbus_message_iter_init_append(signal, &iter); > + dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, > + DBUS_TYPE_OBJECT_PATH_AS_STRING, &array); Would be cleaner to refactor connman_dbus_property_append_array() to reuse common code there. > + > + dbus_message_iter_init_append(signal, &iter); > + dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, > + DBUS_STRUCT_BEGIN_CHAR_AS_STRING > + DBUS_TYPE_OBJECT_PATH_AS_STRING > + DBUS_TYPE_ARRAY_AS_STRING > + DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING > + DBUS_TYPE_STRING_AS_STRING > + DBUS_TYPE_VARIANT_AS_STRING > + DBUS_DICT_ENTRY_END_CHAR_AS_STRING > + DBUS_STRUCT_END_CHAR_AS_STRING, &array); and again, refactoring connman_dbus_property_append_dict() to reuse common code also. > + > + list = services_notify->added; > + services_notify->added = NULL; > + > + while (list != NULL) { > + struct connman_service *srv = list->data; > + DBG("adding %s", srv->path); > + next = list->next; > + append_struct(list->data, &array); > + g_slist_free_1(list); > + list = next; > + } Cheers, Tomasz _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
