Hi Alok,

On 03/21/2012 01:08 PM, Alok Barsode wrote:
From: Alok Barsode<[email protected]>

This property helps to add service specific
timeservers.
---
  include/service.h |    1 +
  src/service.c     |   65 +++++++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 66 insertions(+), 0 deletions(-)

@@ -3485,6 +3549,7 @@ static void service_free(gpointer user_data)
        g_strfreev(service->timeservers);
        g_strfreev(service->nameservers);
        g_strfreev(service->nameservers_config);
+       g_strfreev(service->timeservers_config);
        g_strfreev(service->nameservers_auto);
        g_strfreev(service->domains);
        g_strfreev(service->proxies);

Very minor issue but could you put the timeservers_config next to timeservers so that related items are next to each other, like this:

        g_strfreev(service->timeservers);
 +      g_strfreev(service->timeservers_config);
        g_strfreev(service->nameservers);
        g_strfreev(service->nameservers_config);
        g_strfreev(service->nameservers_auto);


Cheers,
Jukka
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to