Hi,

On Tue, 2012-03-20 at 14:33 +0200, Jukka Rissanen wrote:
> +             if (ret != 0)
> +                     break;

Can we just log an error and continue with the next route/netmask?

> +                     if (g_str_equal(key, "UserNetworks") == TRUE) {
> +                             g_free(provider->user_networks);
> +                             provider->user_networks =
> +                                     g_key_file_get_string(keyfile,
> +                                                     provider->identifier,
> +                                                     key, NULL);

Would it be useful to get/set using g_key_file_{g,s}et_string_list here?
Or should we avoid *_string_list in settings files in ConnMan in
general?

Cheers,

        Patrik


_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to