Hi,

On Wed, 2012-03-21 at 16:02 +0200, Tomasz Bursztyka wrote:
> +static int _wifi_scan(struct connman_device *device,
> +                       GSupplicantInterfaceCallback callback)

I would name this function somehow differently, i.e. not starting with a
single underscore.

> +       } else if (autoscan->interval >= autoscan->limit)
> +               interval = autoscan->limit;
> +       else
> +               interval = autoscan->interval * autoscan->base;

These lines should be switched so that the interval is calculated first
and then comes the check for limit?


Cheers,

        Patrik

_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to