Hi Marcel,

> why are we allowing to send these short passphrases anyway. PSKs have a
> minimum and maximum length. We should reject too short or too long
> passphrases right from the agent callback. Especially since we told the
> UI that expecting as PSK.
>
> And for WEP keys the same thing. Only a few length are valid. And we
> tell the UI that we want a WEP key. If it sends back invalid length, we
> should not even other trying to connect.

I'm ok with that, we should not try to connect with too short or too
long passphrase.
I resend a patch with some checks inside the function
"request_input_cb" in the file "service.c".
But perhaps we still have to parse this error to prevent future
connection with the same parameters.
If it's not the case, the passphrase is not removed and the agent will
not being requested for new passphrase,
unless the service settings file is removed..

Regards,
Julien
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman

Reply via email to